Skip to content

General filter chit-chat #7

Closed
Closed
@THEtomaso

Description

@THEtomaso

Edit by Dandelion Sprout 25th of February 2020: GitHub spectacularly failed to tell me that there was a comment limit of 2,500 comments in issue threads?! So now it seems that discussion has been forcibly moved to #63 instead.

———————————————————————————————————

This thread is a megathread about adblock discussions in general. Here one can request syntax help, reproduction confirmations, info about differences between adblockers, assistance with making new lists, and so on. They'll be answered or considered by the biggest Adfilt contributors, and occasionally by members of the uBlock Origin development team (although in an unofficial fashion). (This header section was last updated on the 24th of April 2019 by DandelionSprout.)

None of the rules for this thread are obligatorily enforced, but are considered customary as of at the time of the last edit:

  • Anything ad-, adblocker-, and adblocking-related of any sort goes.
  • Temporary derails are permitted.
  • Political discussions are only permitted if they are directly related to something adblock-related.
  • Disclosing personal opinions about everyday topics (e.g. family life, non-tech worklife, strong political stances, pizza toppings) is normally discouraged, on the assumption that it could lead to thread participants losing some of their respect for one another.
  • When mentioning websites that are (not) affected by adblocking, it is customary to wrap website names and adblocker entries into ` (Grave accents). This will allegedly make it harder for the websites to find this thread in search engines.
  • Swearing is normally permitted, but is considered bad form. Swearing as a part of an insultment is even more of a bad form.
  • While the following has not been a problem in this thread, they have been sporadic problems among uBO enthusiasts: It is advised to not be hyper-excited when writing comments, whereas reporting thread participants or this repo to GitHub (unless you have a very good reason) is probable grounds for insta-removal from the thread and for the humiliation and pariah-ism of you from the uBlock Origin community.
  • If you wish to emote-react to your own comment: Why not use Windows+. to insert the emote into the end of the actual comment instead? It'll save some vertical space as well. (This rule is sleeping for W7 users until 14th of January 2020, and for W8 users until further notice.)

This thread originally started out as a simple report about removing the blurring from the preview of a premium news article, and is still visible below this line:

———————————————————————————————————

Affected site:

https://www.aftenposten.no/

Example:

https://www.aftenposten.no/karriere/Viktoria-16-betaler-n-million-for-en-karrire-som-ender-nar-hun-er-40-12051b.html

Issue:

Cosmetic filtering blocks the "salesposter" for subscription articles.
This results in strangely abrupted page layouts, that gives you the impression that the pages haven't loaded properly, or has some type of error on them.
As annoying as these type of "salesposters" may look, it's better not to block them, to avoid confusion!

Problem filter:

Dandelion Sprouts norske filtre for ryddigere nettsider

Problem rule:

aftenposten.no##.widgets.widget-salesposter

--

  • OS/version: Windows 8.1 Pro (x64)
  • Browser/version: Pale Moon v27.9.3 (x64)
  • Adblock Extension/version: uBlock Origin v1.16.4.2 (XUL)

Activity

DandelionSprout

DandelionSprout commented on Jul 16, 2018

@DandelionSprout
Owner

At least originally, I felt it was a problem that the sales poster also blurred out the lower lines of the articles previews, and that it would therefore be better for people who didn't intend to subscribe, to remove the blur (which it appears to me that I can't do without also blocking the sales poster).

However, this is a perfectly good issue report and feedback, so I'll look into resolving this issue within the next 15min.

THEtomaso

THEtomaso commented on Jul 16, 2018

@THEtomaso
Author

I felt it was a problem that the sales poster also blurred out the lower lines of the articles previews

I think it only blures out the last line partially.
The line is still readable too, so it's not an issue.

Thanks for the quick fix! :)

DandelionSprout

DandelionSprout commented on Jul 16, 2018

@DandelionSprout
Owner

For me it seemed to give a slight blur to the last two lines, but that's just pedantics of mine. 😄

Closing the issue now that it has been fixed.

DandelionSprout

DandelionSprout commented on Jul 16, 2018

@DandelionSprout
Owner

Update:

After an hour of trial and error, I eventually uncovered that the line blur stemmed from aftenposten.no##.widgets-salesposter:before, with :before being some kind of pre-emptive pseudo-child-element that I've had very little prior experiences with.

Having now accomplished this win-win situation, I'll add the new and vastly improved entry to the list sometime today.
image

added a commit that references this issue on Jul 16, 2018
THEtomaso

THEtomaso commented on Jul 16, 2018

@THEtomaso
Author

aftenposten.no##.widgets-salesposter:before

Nice catch! :)

THEtomaso

THEtomaso commented on Aug 1, 2018

@THEtomaso
Author

Same thing @ digi.no

Example:
https://www.digi.no/artikler/442745/

Fix:
digi.no##.faded-article-content:after

DandelionSprout

DandelionSprout commented on Aug 1, 2018

@DandelionSprout
Owner

Splendidly done of you to have researched it enough to have created a fix entry for it. This'll of course be added to the filter list as soon as possible. 💜

added a commit that references this issue on Aug 1, 2018
THEtomaso

THEtomaso commented on Aug 1, 2018

@THEtomaso
Author

Those type of pseudo-element syntaxes works just fine with uBO.
..but after a recent discussion in the Pale Moon forum, I discovered that ABP-based blockers seems to use a different method (see post 7):
https://forum.palemoon.org/viewtopic.php?f=46&t=19682/
Perhaps you're able to make sense of it?

DandelionSprout

DandelionSprout commented on Aug 1, 2018

@DandelionSprout
Owner

It doesn't seem to be possible to do it in Adblock Plus at all, from what I can determine.

Adblock Plus' syntax is quite the mess, since I suspect that they're using their goal of encouraging better ads, as a bad excuse to refuse to support new features that originate from other adblockers (e.g. URL wildcards á la google.* in element blocking rules, :has-text, etc.). Coupled with poor documentation (to the point where uBlock Origin GitHub issue threads are more informative about ABP features than ABP's official websites), few examples of such ABP-formatted entries in active use, and that I frankly don't even want to test my lists in Adblock Plus due to its simplified UI, indicates that I think that Adblock Plus is outdated and that I can't recommend its everyday usage in all but the most narrow of cases.

DandelionSprout

DandelionSprout commented on Aug 1, 2018

@DandelionSprout
Owner

There is the small theorethical possibility that it's possible to trick :-abp-properties into only detecting :before and :after elements, but I wouldn't place my bets on it. Plus that :-abp-properties isn't even supported in uBO or Nano due to performance concerns (Okay, so advanced adblockers aren't 100% universally covering, either, I must admit), so I can't use Nano's element picker to experiment with it.

THEtomaso

THEtomaso commented on Aug 1, 2018

@THEtomaso
Author

Thanks for elaborating.

2712 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @JustOff@gorhill@pgl@Resike@jspenguin2017

        Issue actions

          General filter chit-chat · Issue #7 · DandelionSprout/adfilt